The code reviews I've given for Valentina and Michael is given within this link:
https://docs.google.com/document/d/18C-dDro7rwCim8owUT61LqdoouG8dW7e4n59Zsslfrs/edit?usp=sharing
With that being said, most of the feedback I've received is that I have highly detailed comments that makes it easy for anyone to follow along but that my code is not the most optimized. In particular I could had utilized HashMaps but instead I used multiple elementary for loops.
As for my struggles, just like always, it was always with the little details. For example, when running the program, messages get printed infinitely because my monster was not fainting (as decrementing wasn't properly set). Or how I forgot to set a different minimum and maximum values for FlowerDino and FireLizard and that set off a whole bunch of errors when running the tests. The project itself wasn't hard; however, I wouldn't say writing code is easy either. I do believe I am getting better intuitions though the more I practice.
I would say my "victory" is less so on about finishing the assignment and more so on what I learned and gained by comparing my code to my teammates. For example, seeing how they utilized HashMaps or realizing I could have done switch-cases (instead of a whole bunch of if and if-else) made me more cognizant of the different implementations I can use.
No comments:
Post a Comment